Move ClassDefinitionPrinters loading later in the bootstrap process #17661
+101
−116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClassDefinitionPrinters package is currently loaded by Hermes alongside the compiler. But this is needed only for tooling, the compiler does not need it except in the UI package. I propose to load it later in the bootstrap process so that it gets loaded by Metacello normaly and not by Hermes
|
Sounds good to me. |
jecisc
added
the
Status: Need more work
jecisc
added
Status: Need more work
jecisc
added
Status: Tests passed please review!
and removed
Status: Need more work
|
Tests are now passing |
MarcusDenker
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ClassDefinitionPrinters package is currently loaded by Hermes alongside the compiler. But this is needed only for tooling, the compiler does not need it except in the UI package.
I propose to load it later in the bootstrap process so that it gets loaded by Metacello normaly and not by Hermes